I am starting today by running more of the test suites to see if the changes have broken anything unrelated. So far so good, except for finding that the build+test script was running the specific test “0”(uninitialized variable).
Resource testing seems to fail on the same spots as before erratically. I’m going to assume that that’s fixed in main.
I should really pull from main sooner rather than later, rebasing could get tricky if I’m not careful.
Oddly enough, moving the delay server tests towards using the .reload_configuration() made things slower, this seems to be because until now, the delay server did not refresh the amount of time it waits for. I suspect that there will be many more instances of things like that.
Showing that to be true, the delay server will need to be kicked over whenever the number of executors or the size of the queue changes, as it does not appear that boost::asio::thread_pool supports changing the number of threads mid-lifetime. I should be able to swap it out after calling .stop and .join on the thread pool(I will not use placement new for assignment) :p
Right now, it appears to not be killing the delay server properly. Or grandpa(the toplevel irods process) is falling down unexpectedly.
I need to run over some of this stuff with K and T tomorrow.
The delay server should use the hook manager to change the executor count, and it should probably use .reload instead of .capture
Leave a Reply
Only people in my network can comment.